perf: fetch withdrawals in parallel when possible #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
spsjvc
changed the title
spsjvc
commented
Dec 17, 2024
Comment on lines
-103
to
-118
| const gateways = await getGateways(provider) | ||
| const senderNonce = await backOff(() => getNonce(sender, { provider })) | ||
|
|
||
| // sender queries; only add if nonce > 0 | ||
| if (senderNonce > 0) { | ||
| addQuery(buildQueryParams({ sender, gateways: [gateways.standardGateway] })) | ||
| addQuery(buildQueryParams({ sender, gateways: [gateways.wethGateway] })) | ||
| addQuery(buildQueryParams({ sender, gateways: [gateways.customGateway] })) | ||
| addQuery(buildQueryParams({ sender, gateways: gateways.otherGateways })) | ||
| } | ||
|
|
||
| // receiver queries | ||
| addQuery(buildQueryParams({ receiver, gateways: [gateways.standardGateway] })) | ||
| addQuery(buildQueryParams({ receiver, gateways: [gateways.wethGateway] })) | ||
| addQuery(buildQueryParams({ receiver, gateways: [gateways.customGateway] })) | ||
| addQuery(buildQueryParams({ receiver, gateways: gateways.otherGateways })) |
There was a problem hiding this comment.
baiscally, all this was moved to fetchWithdrawals so you can have some more control from the outside
fionnachan
reviewed
Dec 18, 2024
packages/arb-token-bridge-ui/src/util/withdrawals/fetchWithdrawals.ts
Outdated
Show resolved
Hide resolved
fionnachan
approved these changes
Dec 19, 2024
| @@ -1,4 +1,4 @@ | |||
| import { StaticJsonRpcProvider } from '@ethersproject/providers' | |||
| import { Provider, StaticJsonRpcProvider } from '@ethersproject/providers' | |||
brtkx
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Steps to test